Fix some libc functions crashing#1351
Draft
apaillier-ledger wants to merge 1 commit intomasterfrom
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1351 +/- ##
=======================================
Coverage 78.60% 78.60%
=======================================
Files 42 42
Lines 4571 4571
Branches 669 669
=======================================
Hits 3593 3593
Misses 928 928
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Cool @apaillier-ledger ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Was noticed and worked around in some apps like there.
Here is newlib's strcasecmp in various configurations :
-fropi -frwpiflags :As noted by the wise @0pendev here, LLVM 19 is required as newlib can't be built with clang 14 currently used with the app-builder docker containers, so we'll probably wait for their migration to Debian 13 that comes with it by default. 🚨
And also libgloss has issues being built by something other than GCC, so it has been disabled as well.
Changes include
Auto cherry-pick in API_LEVEL
[x] TARGET_API_LEVEL: API_LEVEL_25